401

(65 replies, posted in Code)

I now see better how it looks in doxygen

first test file/class

402

(65 replies, posted in Code)

I got it working thanks

403

(65 replies, posted in Code)

ok
I leave French in, the removal can be tackled for version 1.0. for example.

404

(65 replies, posted in Code)

For now I leave the french documentation and add the english text
But what is the intention in the future?
Everything to english or bilingual( eg: english and french).
I ask this because the documentation needs to be maintained.

I also note that the code contains two(or more) styles, likewise for the documentation

styles:(there is both good code and less good code)
Agree this is criticism but I am less critical in the meantime, the code is not bad.
There is simply still a lot of room for improvement.

405

(65 replies, posted in Code)

-Mod doc's
-Fix-indentation-code
-Wrap-code

406

(65 replies, posted in Code)

-doxygen is fine.
-Mod doc's
-todo: will add Commit information in contrib.MD (source: github)

407

(65 replies, posted in Code)

fantastic this seems to be a source of information I will look at this further tomorrow.

408

(65 replies, posted in Code)

scorpio810
can I try to make the other documentation of the functions in Qdoc?
https://doc.qt.io/qt-5/01-qdoc-manual.html

or is this unnecessary?

409

(65 replies, posted in Code)

add documentation of some functions, removed Q_UNUSED for used value's and a fix white space

410

(0 replies, posted in Code)

In light of, among others, git, the development of QElectroTech.
We will have to make a choice.

By Vincent Driessen March 5, 2020 wrote:

If your team is doing continuous delivery of software, I would suggest to adopt a much simpler workflow (like GitHub flow) instead of trying to shoehorn git-flow into your team.

If, however, you are building software that is explicitly versioned, or if you need to support multiple versions of your software in the wild,
then git-flow may still be as good of a fit to your team as it has been to people in the last 10 years.

It comes down to this:

  • git-flow
    two main branches, and of course a lot of temporary branches
    We consider origin/master to be the main branch where the source code of HEAD always reflects a production-ready state.
    We consider origin/develop to be the main branch where the source code of HEAD always reflects a state with the latest delivered development changes for the next release. Some would call this the “integration branch”. This is where any automatic nightly builds are built from.

    benefit:
    - a production-ready software
    - Hotfix branches:
      The essence is that work of team members (on the develop branch) can continue, while another person is preparing a quick production fix.

  • GitHub flow
    one main branche, and of course a lot of temporary branches
    We consider origin/master to be the main branch where the source code of HEAD always reflects a state with the latest delivered development.

    benefit:
    -support only one version, the last one
    -simple

I recommend everyone to read the git-flow URL which contains the full text, my post may seem a bit difficult.

Why:
-to make full use of git.
-for the change log
-... and many many more

412

(22 replies, posted in Code)

scorpio810 wrote:

@Simon,
as with each release taking inventory of the changes and functionalities added is a big headache..
If you know a good method to update changelog
https://stackoverflow.com/questions/352 … -using-git

I think this is possible

git shortlog $(git describe --tags --abbrev=0)..HEAD

As a source, you have to clean up afterwards.

to send it to a file add

 > mylist.txt

413

(317 replies, posted in News)

scorpio810 wrote:

Toutes les dates dans QET sont basées sur SystemLocaleShortDate ce qui permet de remplacer automatiquement le format date dans tous tes folios suivant ton client ou en fonction de la configuration PC chez ton client.

https://git.tuxfamily.org/qet/qet.git/l … eShortDate

note:
This enum value is deprecated and shall be removed in Qt 6.
https://doc.qt.io/qt-5/qt.html#DateFormat-enum

add info
https://doc.qt.io/qt-5/qlocale.html#FormatType-enum

414

(22 replies, posted in Code)

scorpio810 wrote:

In English off course. nomicons/wink
Pages in French isn't a good idea, now I think.

google translate?

"now I think." seems strange to me (no context)

anyway, give me some time to figure out the wiki.

I suspect I should find out what is missing for developers, we can use them to add the missing feature.

i had a hard time getting the missing the modules:
- KwidgetAddons
- KcoreAddons
see post:
https://qelectrotech.org/forum/viewtopi … 041#p10041

after that, Qdebug did not work.

QT's SDK also made it difficult eg:
preprocessor Issue error: 'foo.h' file not found

Posts
https://qelectrotech.org/forum/viewtopi … 880#p10880
was a big help, but the linux distro was to difference, making it more guideline than manual

415

(22 replies, posted in Code)

scorpio810 wrote:

Hi Simon

I added you on Wiki if you interest to add some informations.

Okay, no problem but, my main language is Dutch, for french, i pass.

416

(22 replies, posted in Code)

git commit message template
!__draft__!

file: ".gitmessage.txt"

Subject: Capitalized, short, summary, imperative

     Body of commit message is a few lines of text, explaining things 
in more detail, possibly giving some background about the issue being 
fixed, etc etc.
     The body of the commit message can be several paragraphs, and 
please do proper word-wrap and keep columns shorter than about 74 
characters or so. That way "git log" will show things nicely even when 
it's indented.
     Make sure you explain your solution and why you're doing what 
you're doing, as opposed to describing what you're doing. Reviewers 
and your future self can read the patch, but might not understand why 
a particular solution was implemented.
#
# Subject line:
# * Begin all subject lines with a capital letter
# * Do not end the subject line with a period
# * Limit the subject line to 50 characters
# * Use the imperative mood in the subject line
#    A properly formed Git commit subject line should 
#    always be able to complete the following sentence:
#    - If applied, this commit will your subject line here
#
#    eg: 
#       If applied, this commit will 
#        - Remove deprecated methods
#        - Update qelectrotech gui
#        - Add file/feature autonumber
#
# Separate subject from body with a blank line
#
# Wrap the body at 74 characters/line
# Use the body to explain what and why vs. how
#
git config --local commit.template .gitmessage.txt

https://git-scm.com/book/en/v2/Customiz … figuration
your thoughts?

417

(22 replies, posted in Code)

I'm trying to edit the "CONTRIBUTING.md" file for the changelog Generator with Git, but I'm struggling with the "Commit Message Format" as a user of qelectrotech.
I want to make it easy and simple, but then we are probably missing a few fixes and improvements in the changelog.
I was first thinking about:
https://github.com/angular/angular/blob … guidelines

too complex.

But one night about sleep does wonders.

note:
I remain in favor of the use of branching.
Because a merge also requires a Commit.
And this can then be properly formatted.

remainder for me
https://chris.beams.io/posts/git-commit/

418

(22 replies, posted in Code)

The Conventional Commits

specification is a lightweight convention on top of commit messages. It provides an easy set of rules for creating an explicit commit history; which makes it easier to write automated tools on top of. This convention dovetails with SemVer, by describing the features, fixes, and breaking changes made in commit messages.

https://www.conventionalcommits.org/fr/v1.0.0/

fix => Joshua
https://git.tuxfamily.org/qet/qet.git/c … 2d235417cf

@@ -1186,12 +1186,12 @@ QString DynamicElementTextItem::reportReplacedCompositeText() const
         {
             if(string.contains("%{function}"))
                 string.replace("%{function}", m_watched_conductor.data()->properties().m_function);
-            if(string.contains("%{tension-protocol}"))
-                string.replace("%{tension-protocol}", m_watched_conductor.data()->properties().m_tension_protocol);
-            if(string.contains("%{}couleur-conducteur"))
-                string.replace("%{couleur-conducteur}", m_watched_conductor.data()->properties().m_wire_color);
-            if(string.contains("%{}section-conducteur"))
-                string.replace("%{section-conducteur}", m_watched_conductor.data()->properties().m_wire_section);
+            if(string.contains("%{tension_protocol}"))
+                string.replace("%{tension_protocol}", m_watched_conductor.data()->properties().m_tension_protocol);
+            if(string.contains("%{conductor_color}"))
+                string.replace("%{conductor_color}", m_watched_conductor.data()->properties().m_wire_color);
+            if(string.contains("%{conductor_section}"))
+                string.replace("%{conductor_section}", m_watched_conductor.data()->properties().m_wire_section);
         }
     }

420

(22 replies, posted in Code)

I would keep it general for the changelog, eg only features and refer the rest to the git log.

421

(22 replies, posted in Code)

yes, you have to do the release more frequently...... this can no longer be read normally.

what is the language?
and the version of Qelectrotech?
It is possible that there is an error in the hotkeys, as was the case here with the "Space".
https://qelectrotech.org/forum/viewtopi … 906#p11906

423

(22 replies, posted in Code)

scorpio810 wrote:

their location

# Print out a list of files which was updated/added between the 2 commits
git whatchanged <TAG_NAME>...HEAD
git whatchanged $(git describe --tags --abbrev=0)..HEAD --pretty=format:"%s" -i -E --grep="^(TS|ts)*add|fix|feature"

or a file (titleblocks)

git log --pretty=format:"%ar : %s , %an" titleblocks
5 months ago : Fix # bug 182, thanks Wilfried , Laurent Trinques
1 year, 6 months ago : Add template , scorpio810
4 years, 1 month ago : Update Danish translation titleblocks , ossau2mation
4 years, 2 months ago : Update Danish translation default titleblock , ossau2mation
4 years, 2 months ago : Titleblocks/default.titleblock - Enable custom text in Folio Field , dfochi
5 years ago : updated Polish translation - titleblocks , pawel32640
5 years ago : Update Greek translation , aitolos
5 years ago : Update elements Greek translation , aitolos
6 years ago : Update translation netherland and ISO7200_A4_V1.titleblock , scorpio810
6 years ago : Add new titleblock, thanks Paul , scorpio810
7 years ago : elements, Greek translation , aitolos
8 years ago : Update translation to A4_1.titleblock ,DIN_A4.titleblock . , scorpio810
8 years ago : Translated double-logo and single-logo titleblocks to all potentially supported languages. , xavier
8 years ago : Translated the default title block template in all potentially supported languages. , xavier
8 years ago : update Polish translation: qelectrotech,xml, x-qet-titleblock.xml, default.titleblock , pawel32640
8 years ago : Fix typo in croate translation default.titleblock . , scorpio810
8 years ago : Translated default title block template thanks to Antun Marakovic's work. , xavier
8 years ago : Refresh titeblock A4_1 to use the entire page . , scorpio810
8 years ago : Change logo , scorpio810
8 years ago : Add other TBT , scorpio810
8 years ago : Minor change in TBT DIN_A4 , scorpio810
8 years ago : Refresh n°2 TBT DIN_A4 , scorpio810
8 years ago : Refresh Titleblock DIN_A4 , scorpio810
8 years ago : Add new titleblock DIN A4 , first works , scorpio810
8 years ago : Added two simple title block templates. , xavier
9 years ago : Indentation fix. , xavier
9 years ago : update italian translation , drslump
9 years ago : Titleblock templates values and labels can now be translated. , xavier
10 years ago : Changed every occurence in the code of the "inset" term to "title block". , xavier

elements sins 0.8 dev

git log $(git describe --tags --abbrev=0)..HEAD --pretty=format:"%ar : %s , %an" elements

424

(22 replies, posted in Code)

if we want to use "git log" in the future, we will have to make the git comits more strict, or use "merge commit messages"

Let’s assume you have agreed in your project to prefix git commit messages with one or more of certain prefixes (not necessarily for all changes/commits):

Annotation  Description                Example git commit
[INTERNAL]  used for internal stuff    git commit -m “[INTERNAL] my internal change”
[FIX]       contains a bugfix          git commit -m “[FIX] my fix change”
[FEATURE]   contains a new feature     git commit -m “[FEATURE] my new feature”
[DOC]       contains documentation     git commit -m “[DOC] my documentation change”

bv:

git log $(git describe --tags --abbrev=0)..HEAD --pretty=format:"%ar : %s , %an" -i -E --grep="^(\[INTERNAL\]|\[FEATURE\]|\[FIX\]|\[DOC\])*fix" > myfix.txt
2 weeks ago : Fix crash. , Claveau Joshua
2 weeks ago : fix tr() cannot be called without context , Simon De Backer
3 weeks ago : fix deprecated warning int QWheelEvent::delta() const , Simon De Backer
2 weeks ago : fix Wmisleading-indentation , Simon De Backer
3 weeks ago : fix Wdeprecated-declarations , Simon De Backer
2 weeks ago : fix fail to build , Claveau Joshua
6 weeks ago : fix segmentation fault , Martin Marmsoler
6 weeks ago : fix nullpointer exception , Martin Marmsoler
3 weeks ago : Fix FTBFS on Ubuntu 18.04 , Laurent Trinques
6 weeks ago : fix segmentation fault , Martin Marmsoler
6 weeks ago : fix nullpointer exception , Martin Marmsoler
3 weeks ago : Fix FTBFS QTextStreamFunctions::endl(QTextStream&) , Laurent Trinques
4 weeks ago : fix deprecated warning QTextStream& QTextStreamFunctions::endl(QTextStream&) , Simon De Backer
4 weeks ago : fix deprecated warning Qt::WindowFlags = nullptr , Simon De Backer
4 weeks ago : fix deprecated warning void QGraphicsView::resetMatrix() , Simon De Backer
4 weeks ago : fix deprecated warning QMatrix QGraphicsView::matrix() const , Simon De Backer
4 weeks ago : fix deprecated warning int QWheelEvent::delta() const , Simon De Backer
3 weeks ago : Fix Unbutu 18.04 FTFS , Laurent Trinques
4 weeks ago : fix deprecated warning QString::SplitBehavior , Simon De Backer
4 weeks ago : fix deprecated warning qsrand , Simon De Backer
4 weeks ago : fix deprecated warning QButtonGroup::buttonClicked , Simon De Backer
4 weeks ago : fix deprecated warning QHash , Simon De Backer
4 weeks ago : fix deprecated warning QMap , Simon De Backer
4 weeks ago : fix deprecated warning QDirModel , Simon De Backer
6 weeks ago : fix segmentation fault , Martin Marmsoler
6 weeks ago : fix nullpointer exception , Martin Marmsoler
4 weeks ago : fix deprecated warning QSet<T> QList<T>::toSet() , Simon De Backer
4 weeks ago : fix deprecated warning qUpperBound , Simon De Backer
4 weeks ago : fix deprecated warning QList::swap() attempt 2 , Simon De Backer
4 weeks ago : fix deprecated warning QModelIndex::child , Simon De Backer
5 weeks ago : fix deprecated warning QPainter::drawRoundRect , Simon De Backer
5 weeks ago : fix deprecated warning QTreeWidgetItem::setBackgroundColor , Simon De Backer
5 weeks ago : fix deprecated warning QDrag::start , Simon De Backer
5 weeks ago : fix deprecated warning QList::swap() , Simon De Backer
5 weeks ago : fix deprecated warning QDir& QDir::operator=(const QString&) , Simon De Backer
5 weeks ago : fix -Wswitch warning , Simon De Backer
5 weeks ago : fix deprecated warning qVariantFromValue , Simon De Backer
5 weeks ago : fix deprecated warning QLineF::intersect , Simon De Backer
5 weeks ago : fix deprecated warning QTime::start() , Simon De Backer
5 weeks ago : fix deprecated warning QFontMetrics::width(QChar ch) , Simon De Backer
5 weeks ago : fix -Wmisleading-indentation warning , Simon De Backer
6 weeks ago : fix deprecated warning QSet<T>::toList() Use values() instead. , Simon De Backer
9 weeks ago : Fix : key sequence 'space' don't work with nl be local , Laurent Trinques
9 weeks ago : Fix : key sequence 'space' don't work with nl be local , Claveau Joshua
9 weeks ago : Fix typo , Laurent Trinques
9 weeks ago : Fix wrong element text value when loading from xml , Claveau Joshua
10 weeks ago : Fix missing many languages after run make install or made any distro specific package, thanks Charles , Laurent Trinques
3 months ago : snap: Set correct PYTHONPATH , Maximilian Federle
3 months ago : Fix break from merge of qetgraphicsTableItem to master , Claveau Joshua
3 months ago : Fix crash when close project , Claveau Joshua
5 months ago : Fix # bug 182, thanks Wilfried , Laurent Trinques
7 months ago : Fix crash when quickly move tab of digramview , joshua
7 months ago : fixed syntax error in hungarian translation , artgg7300
8 months ago : Fix typo , Laurent Trinques
8 months ago : Fix symbol state , Laurent Trinques
9 months ago : Fix crash when a .qet file with 0 diagrams. , joshua
10 months ago : Fix : element prefix don't work with custom path of user elements collection , joshua

De-Backer wrote:

ctrl + E
Tab
Tab
entering the properties of an element. (“Formula du labe”)
Alt + T

Alt + T == is the "apply" button.

https://qelectrotech.org/forum/viewtopi … 985#p11985