Search options (Page 1 of 305)

crossrefitem: fix SIGSEGV crash + improve double-click navigation + fix PDF/SVG/print rendering

Fix a use-after-free crash (SIGSEGV in QRegion::begin, Qt5Gui+0x49af60)
confirmed by analysis of 19 coredumps. The crash was triggered when the
scene viewport clip region was freed during zoom/resize events while
QPicture::play() replayed drawPolyline commands through the scene painter.
Qt's raster engine then dereferenced a stale QRegionData pointer.

Root cause: CrossRefItem used three nested QPicture objects (m_drawing,
m_hdr_no_ctc, m_hdr_nc_ctc). The nested drawPicture() calls amplified
the use-after-free risk on any repaint event.

Fix: remove all QPicture from CrossRefItem entirely.
- updateLabel() now uses a QImage-backed dummy painter to compute
  m_bounding_rect, m_shape_path and m_hovered_contacts_map geometry.
  A bool m_update_map flag prevents the map from being overwritten
  during paint().
- paint() calls drawAsCross()/drawAsContacts() directly on the scene
  painter — no QPicture::play() anywhere in the class.
- buildHeaderContact() now draws NO/NC symbols directly onto the painter
  instead of recording them into QPicture members.

Also fix mouseDoubleClickEvent: the element under the click is now found
directly from m_hovered_contacts_map using the event position, rather
than relying on m_hovered_contact which could be reset by hoverMoveEvent
between the two clicks of a double-click.

Also remove setBold(true) on terminal name labels: the Qt PDF/SVG/print
engine rendered bold at 4pt as extremely thick glyphs, making exports
unreadable. Normal weight at 4pt is correct and legible on all backends.

Fixes: SIGSEGV in CrossRefItem::paint() on zoom/resize
Fixes: double-click navigation unreliable on Xref contact symbols
Fixes: terminal name labels unreadable in PDF/SVG/print export

Please try the new package builds for all of us who use nightly builds in production like us.

Hi all,

Following the previous work on terminal name display in cross-references, I've added a new option to disable this feature per xref type, as Achim had recommended.

A new checkbox "Show terminal numbers in Xrefs" (Show terminal names in Xrefs) has been added to the XRef properties widget, in the main display group — so it is available in both Cross and Contacts modes.

When unchecked, terminal names are hidden in all rendering paths:
- drawContact() — Contacts mode (NO/NC/SW symbols)
- fillCrossRef() — Cross mode (NO and NC columns)
- setUpCrossBoundingRect() — Cross mode (bounding rect sizing)

The new boolean property 'showTerminalName' (default: true) is fully persisted in XML and QSettings, so existing project files are not affected (backward compatible).

Also included in the same patch series: a fix for power contact terminal pairing in Contacts mode. The previous alphanumeric sort was breaking consecutive-pair grouping for terminals named L1,L2,L3,T1,T2,T3 — pole 0 was showing L1/L2 instead of L1/T1. Terminal names are now used in declaration order from the element editor; users must declare pairs consecutively (e.g. L1,T1,L2,T2,L3,T3).

Files changed:
- sources/properties/xrefproperties.h
- sources/properties/xrefproperties.cpp
- sources/ui/xrefpropertieswidget.ui
- sources/ui/xrefpropertieswidget.cpp
- sources/qetgraphicsitem/crossrefitem.cpp

Joshua, Achim, plc-user, Kellermorph — thoughts?

Additional fix pushed today: crossrefitem: fix SIGSEGV when dropping a power NC contact on the folio

A reproducible crash (SIGSEGV in QRegion::begin) occurred as soon as a power NC slave element was placed on a folio, even before linking it to a master element.

Three bugs were found and fixed in crossrefitem.cpp:

1. m_drawing (QPicture) was never reset between updateLabel() calls.
QPicture accumulates paint commands — calling qp.begin() on an existing QPicture appends to it rather than replacing its content. After several updates (load, move, hover...) the picture became corrupted and crashed on play().
Fix: reset m_drawing = QPicture() at the start of updateLabel().

2. m_drawed_contacts was only initialized to 0 in drawAsContacts(), but not in drawAsCross().
When drawing in Cross mode, fillCrossRef() called drawContact() with an uninitialized m_drawed_contacts value, producing a garbage offset. The NC contact symbol uses drawPolyline() with a sub-pixel Y coordinate (offset+2.5); with a random offset Qt generated an invalid QRegion and crashed.
This explains why NC contacts crashed but NO contacts did not: the NO symbol only uses drawLine() which is more tolerant of bad coordinates.
Fix: add m_drawed_contacts = 0 at the start of drawAsCross().

3. setUpCrossBoundingRect() used QRectF() (null rect) as the reference rect for painter.boundingRect(), which can return invalid dimensions. Additionally, height was accumulated incorrectly: united() + setHeight() doubled the height at each iteration, causing an exponentially growing bounding rect with multiple contacts.
Fix: use QRectF(0, 0, 500, 20) as reference rect and accumulate height and width independently.

Only crossrefitem.cpp was modified.

@Kellermorph:

FYI, we have now two CI/CD one for snap but in edge channel, and Windows CI/CD github action pushed by me, and we wait to signpath.io mail for valid or cancel signing job before upload Installer, Ready-to-use and MSI to https://qelectrotech.github.io/qelectro … ce-mirror/

By the way I launch my packaging script to packages Debian stable and unstable deb, make PPA Upload, after I launch macOS KVM/Qemu VM for bundle Intel dmg, Open AppImage VM and build new AppImage, I open flatpak VM and build new flatpak.

After I launch my mac Mini M2 for build dmg signed and notarised for macOS Apple silicon, after I launch my Raspery Py 5 for build AppImage for aarch64 Linux.

See log and check the version git hash.
You use my PPA or snap, for snap I don't deploy it to stable channel yet.
Or you use my Debian deb repository?

In older projects, the `terminal_name` tag does not exist; consequently, terminal numbers will not be displayed.
@Achim: you could share an little sample?
What you using list mode or cross for XREFs?
I use only list mode, I hate cross.

Hi all,

Following the previous commit that displays terminal names on contact symbols in Xref (both Contact and Cross modes), I've been working on extending the feature to power contacts and switch (SW) contacts.

Here is what has been implemented:

**Power contacts (e.g. 3-pole contactor, 6 terminals)**

Cross mode: all terminals are collected and sorted numerically → [1-2-3-4-5-6] P1-H9
Contacts mode: each pole displays its own pair:
- Pole 1 → 1 (left) / 2 (right)
- Pole 2 → 3 (left) / 4 (right)
- Pole 3 → 5 (left) / 6 (right)

**SW contacts with typed terminals**

To solve the ambiguity of SW contacts (which appear in both NO and NC columns), TerminalData::Type has been extended with three new semantic values:

  enum Type { Generic, Inner, Outer, No, Nc, Common };

Users can now assign a role to each terminal of a SW element directly in the element editor (new entries in the Type combobox: "NO (contact SW)", "NC (contact SW)", "Commun (contact SW)").

Once typed, the Xref displays the correct pair per column:
- NO column: NO + Common pair, e.g. [14-13]
- NC column: NC + Common pair, e.g. [12-13]
- Contacts mode: NO top-left, NC bottom-left, Common right

Elements without explicit terminal types fall back to the previous behavior (first 2 named terminals) — fully backward compatible.

This change affects:
- terminaldata.h / terminaldata.cpp — new enum values + serialization
- terminal.h / terminal.cpp — new public terminalType() accessor
- terminaleditor.cpp — new entries in the type combobox + pre-existing bug fix in updateForm()
- crossrefitem.cpp — filtering by type in Cross and Contacts modes

Joshua, Achim, plc-user, Kellermorph — what do you think?

EDIT: Pushed to the master branch and compiled the main packages.

@Kellermorph: For the time being, I don’t plan to include the terminal numbers for the power contacts – is that useful, I think no?

Can you test this patch?
last captures is based on!; or I push it?
https://qelectrotech.org/forum/misc.php … download=1

https://github.com/qelectrotech/qelectr … r/pull/464

https://github.com/qelectrotech/qelectr … 86b0ce2636

Ps: it's work on list mode not in cross XREFs
BTW for checting I enter hazardus terminal name in this capture: joke!

Enjoy!

Another step is to control you can't linked an antother slave contact if terminal_name was already into the list.
I don’t think it’s necessary to include the names of power contacts on this list, like contactors..