1 Topic by De-Backer (edited by De-Backer 2020-05-06 19:07:52)

Topic: Shortcut (Space key) for language nl be does not work.

For rotate selection (Shortcut is Space)

does not work for language nl be (this has been since 2019)


file qetdiagrameditor.cpp at line 545

m_rotate_selection->setShortcut(QKeySequence( tr("Space")));

test mod Space to Ctrl+R works

Updating 'lang/qet_be.ts'...
    Found 2294 source text(s) (1 new and 2293 already existing)
    Kept 1 obsolete entries
m_rotate_selection->setShortcut(QKeySequence(tr("Ctrl+R")));

I cannot find the Space key in qt nl be.
does anyone know the key for space?

I have tested "spatie",  "Spatiebalk"

A bug in Qt?

edited :add Screenshot of test with Ctrl+R

Post's attachments

Screenshot.jpg, 29.72 kb, 540 x 396
Screenshot.jpg 29.72 kb, 200 downloads since 2020-05-06 

2 Reply by Joshua (edited by Joshua 2020-05-06 19:06:25)

  • Joshua
  • Joshua
  • QElectroTech Team Developer
  • Offline

Re: Shortcut (Space key) for language nl be does not work.

After test,
m_rotate_selection->setShortcut(QKeySequence( tr("SPACE")));
work well for nl be local and also for french.
I will try for all local and if it's ok I commit the change.

Thanks for report

Développeur QElectroTech
  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Shortcut (Space key) for language nl be does not work.

In theory these QKeySequence names should not be translated by translators, but by framework..
See in qet_fr.ts.

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."

Re: Shortcut (Space key) for language nl be does not work.

uppercase Space
weird, it works in german (lowercase Space)

  • Joshua
  • Joshua
  • QElectroTech Team Developer
  • Offline

Re: Shortcut (Space key) for language nl be does not work.

Work well for every local. Pushed to git master.
Thanks.

Développeur QElectroTech
  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Shortcut (Space key) for language nl be does not work.

https://git.tuxfamily.org/qet/qet.git/t … r.ts#n5775

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Shortcut (Space key) for language nl be does not work.

https://git.tuxfamily.org/qet/qet.git/c … d4640293fe

Well this is an oversight in the Qt translation for be, for example in french I don't need to translate this key, Qt does it alone.

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."

Re: Shortcut (Space key) for language nl be does not work.

@Joshua and scorpio810
great work, can you also change the next line please?
file qetdiagrameditor.cpp at line 546

m_rotate_texts    ->setShortcut(QKeySequence( tr("Ctrl+Space")));

in to

m_rotate_texts    ->setShortcut(QKeySequence( tr("Ctrl+SPACE")));

it is the last space.

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Shortcut (Space key) for language nl be does not work.

@De-Backer,

done, and generated new ts files.

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."