• scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Nice. ;-)
See GIT commit in my previous post.

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

If you can found for mouse scroll tab.
https://doc.qt.io/qt-5/macos-issues.html

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

https://github.com/bjorn/tiled/commit/d … 5769940289

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • bgio
  • Membre
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Interesting!
Should it be inserted and compiled?

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

I think you can try to adapt it maybe in projectView.

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • bgio
  • Membre
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

I could try even if I am so clumsy as you have seen.
But I think I need the updated Mac script to compile with right sources from git.

regards
Giovanni

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Done, but you need to GIT clone before.

git clone git://git.tuxfamily.org/gitroot/qet/qet.git qet_git

And run script like this in a terminal :
bash /Users/laurent/qet_git/misc/MacQetDeploy.sh

Cheers,
Laurent

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Is removed on macOS since Qt 5.5

https://bugreports.qt.io/browse/QTBUG-8428
https://codereview.qt-project.org/c/qt/qtbase/+/109523


https://codereview.qt-project.org/gitwe … 401401ff6f 

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • bgio
  • Membre
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

I have put together whith sources suggested by you, a little app to test the QTabBar scroll on my Mac.
And it works.

Regards
Giovanni

Post's attachments

Attachment icon Esempio QtabBar.zip 13.69 kb, 368 downloads since 2019-09-02 

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Nice, if you have free time to add it in QET code?

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • bgio
  • Membre
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

I could try.
But I need to know how to interface with QET (in which source, with which pointer ...)

Regards
Giovanni

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Look projectview m_tab and qetapp (QTabBar::tab).


Regards,
Laurent

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • bgio
  • Membre
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Can't believe... It works!
I attach the sources without any .dmg file since it seems the forum-system doesn't like it.
On my Mac it works with the same behaviour (problem)  of the test I posted before (scroll too fast etc.)
At the moment I have not separate my modifcations with "define" only for Mac OS.
If the code should compile and work also on other platforms it will be ok. If not I will insert the defines needed to isolate "Mac-only" code.

39 Reply by bgio (edited by bgio 2019-09-05 19:39:50)

  • bgio
  • Membre
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

I can't upload all files in source folder.
Maybe all sources was too big.
I attach modified files.

Regards
Giovanni

Post's attachments

Attachment icon Modified_files.zip 28.85 kb, 342 downloads since 2019-09-05 

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Hi Giovanni,

thank you, it has compiled and run on my Debian machine, but scrolling is too fast to add on other platforms.
Mouse scroll jumps to 2 or 5 tabs, very difficult to use here.
Extracted a git patch for someone want to improve it.

Cheers,
Laurent

Post's attachments

Attachment icon macos_wheel_event_tabbar.diff 1.84 kb, 379 downloads since 2019-09-05 

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Maybe https://doc.qt.io/qt-5/qstyle.html enum QStyle:: https://doc.qt.io/qt-5/qstyle.html#SubControl-enum

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."

42 Reply by bgio (edited by bgio 2019-09-05 21:13:32)

  • bgio
  • Membre
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

I have seen folios scroll at the speed of light nomicons/grin
Actually it was still a test-run. I am happy it compile on Debian too.
I am working to slow down mouse scrolls.
Thank you for the links above, I'll look at them.

Regards
Giovanni

  • bgio
  • Membre
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

The little example modified.
Plese try it. If you like it, maybe tomorrow I could modify qet source.
There are only few changes.

Regards
Giovanni

Post's attachments

Attachment icon Example slow-scroll.zip 398.48 kb, 348 downloads since 2019-09-05 

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Same problem here, wheel is so fast on Debian and macOS too. nomicons/sad
Maybe it's my mouse ? You could confirm it work slowly on your mac?

index 4 temp_index 4.8    -120 -4.8
index 0 temp_index 0    120 4.8
index 4 temp_index 4.8    -120 -4.8
index 9 temp_index 9.6    -120 -4.8
index 4 temp_index 4.8    120 4.8
index 0 temp_index 0    120 4.8
index 4 temp_index 4.8    -120 -4.8
index 9 temp_index 9.6    -120 -4.8
index 4 temp_index 4.8    120 4.8
index 0 temp_index 0    120 4.8
index 4 temp_index 4.8    -120 -4.8
index 9 temp_index 9.6    -120 -4.8
index 4 temp_index 4.8    120 4.8
index 9 temp_index 9.6    -120 -4.8
index 4 temp_index 4.8    120 4.8
index 0 temp_index 0    120 4.8
index 4 temp_index 4.8    -120 -4.8
index 9 temp_index 9.6    -120 -4.8
index 4 temp_index 4.8    120 4.8
index 0 temp_index 0    120 4.8
index -4 temp_index -4.8    120 4.8
index 0 temp_index 0    -120 -4.8
index 4 temp_index 4.8    -120 -4.8
index 9 temp_index 9.6    -120 -4.8
index 14 temp_index 14.4    -120 -4.8
index 14 temp_index 14.4    -120 -4.8
index 14 temp_index 14.4    -120 -4.8
index 9 temp_index 9.6    120 4.8
index 4 temp_index 4.8    120 4.8
index 9 temp_index 9.6    -120 -4.8
index 4 temp_index 4.8    120 4.8
index 9 temp_index 9.6    -120 -4.8
index 4 temp_index 4.8    120 4.8
index 0 temp_index -1.77636e-15    120 4.8
index 4 temp_index 4.8    -120 -4.8
index 9 temp_index 9.6    -120 -4.8
index 4 temp_index 4.8    120 4.8
index 0 temp_index -1.77636e-15    120 4.8
index 4 temp_index 4.8    -120 -4.8
index 0 temp_index -1.77636e-15    120 4.8
index 4 temp_index 4.8    -120 -4.8
index 0 temp_index -1.77636e-15    120 4.8
index 4 temp_index 4.8    -120 -4.8
index 9 temp_index 9.6    -120 -4.8
index 4 temp_index 4.8    120 4.8
index 9 temp_index 9.6    -120 -4.8
index 4 temp_index 4.8    120 4.8
index 0 temp_index -1.77636e-15    120 4.8
index 4 temp_index 4.8    -120 -4.8
index 9 temp_index 9.6    -120 -4.8
index 14 temp_index 14.4    -120 -4.8
index 14 temp_index 14.4    -120 -4.8
index 9 temp_index 9.6    120 4.8
index 4 temp_index 4.8    120 4.8
index 0 temp_index -1.77636e-15    120 4.8
index 4 temp_index 4.8    -120 -4.8
index 9 temp_index 9.6    -120 -4.8
index 14 temp_index 14.4    -120 -4.8
index 14 temp_index 14.4    -120 -4.8
index 14 temp_index 14.4    -120 -4.8
index 14 temp_index 14.4    -120 -4.8
index 14 temp_index 14.4    -120 -4.8
index 14 temp_index 14.4    -120 -4.8
index 9 temp_index 9.6    120 4.8
index 4 temp_index 4.8    120 4.8
index 0 temp_index -1.77636e-15    120 4.8

Cheers,
Laurent

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • bgio
  • Membre
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

I do confirm that on my Mac is slow or even slower if I change scale_factor variable.
Please try to change scale_value to test if speed changes.

Regards
Giovanni

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Hello Giovanni,

I tested it when I got home from work this morning, too tired to have seen the variable scale factor...after a very bad nifght at work..
 scale_factor = 0.01; is fine on my Debian.



And scale_factor = 0.005; is fine on macOS.

index 10 temp_index 10.2    120 0.6
index 9 temp_index 9.6    120 0.6
index 8 temp_index 9    120 0.6
index 8 temp_index 8.4    120 0.6
index 7 temp_index 7.8    120 0.6
index 7 temp_index 7.2    120 0.6
index 6 temp_index 6.6    120 0.6
index 6 temp_index 6    120 0.6
index 5 temp_index 5.4    120 0.6
index 4 temp_index 4.8    120 0.6
index 4 temp_index 4.2    120 0.6
index 3 temp_index 3.6    120 0.6
index 3 temp_index 3    120 0.6
index 2 temp_index 2.4    120 0.6
index 1 temp_index 1.8    120 0.6
index 1 temp_index 1.2    120 0.6
index 0 temp_index 0.6    120 0.6
index 1 temp_index 1.2    -120 -0.6
index 1 temp_index 1.8    -120 -0.6
index 2 temp_index 2.4    -120 -0.6
index 3 temp_index 3    -120 -0.6
index 3 temp_index 3.6    -120 -0.6
index 4 temp_index 4.2    -120 -0.6
index 4 temp_index 4.8    -120 -0.6
index 5 temp_index 5.4    -120 -0.6
index 6 temp_index 6    -120 -0.6
index 6 temp_index 6.6    -120 -0.6
index 7 temp_index 7.2    -120 -0.6
index 7 temp_index 7.8    -120 -0.6
index 8 temp_index 8.4    -120 -0.6
index 8 temp_index 9    -120 -0.6
index 9 temp_index 9.6    -120 -0.6
index 10 temp_index 10.2    -120 -0.6
index 10 temp_index 10.8    -120 -0.6
index 11 temp_index 11.4    -120 -0.6
index 10 temp_index 10.8    120 0.6
index 10 temp_index 10.2    120 0.6
index 9 temp_index 9.6    120 0.6
index 8 temp_index 9    120 0.6
index 8 temp_index 8.4    120 0.6
index 7 temp_index 7.8    120 0.6
index 7 temp_index 7.2    120 0.6
index 6 temp_index 6.6    120 0.6
index 6 temp_index 6    120 0.6
index 5 temp_index 5.4    120 0.6
index 4 temp_index 4.8    120 0.6
index 4 temp_index 4.2    120 0.6
index 3 temp_index 3.6    120 0.6
index 3 temp_index 3    120 0.6
index 2 temp_index 2.4    120 0.6
index 1 temp_index 1.8    120 0.6
index 1 temp_index 1.2    120 0.6
index 0 temp_index 0.6    120 0.6
index 0 temp_index 6.66134e-16    120 0.6

Depending on the mouse used, the best way is to add a Spinbox for the user in the QET settings.

Thanks.

Cheers,
Laurent

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."

47 Reply by bgio (edited by bgio 2019-09-06 22:26:00)

  • bgio
  • Membre
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Thank you for testing it.
i agree for the user setting.
So, let say the scroll and the speed are (almost) working.
Now the problem to solve is the conflict with page zoom also made by scrool wheel.
Tab scroll has to be enabled only when the mouse is over tabs, not in the middle of the page.
I see two possible solutions:
1 orizontal scroll for tabs and vertical scroll for zoom
2 use a "mouse over" function to detect when mouse is over tabs.

I attach the file .h so you can see the scaling method that you have just tested plus solution 1 applied to qet.

Regards
Giovanni

Post's attachments

Attachment icon projectview.h.zip 2 kb, 348 downloads since 2019-09-06 

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Now the problem to solve is the conflict with page zoom also made by scrool wheel.

Yes, it was a problem raised on the Qt report issue and why it was removed for OSX by upstream since 2015.

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."

49 Reply by bgio (edited by bgio 2019-09-07 16:59:08)

  • bgio
  • Membre
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

I haven't edited previous message.
Using horizontal scroll for tabs and vertical scroll for zoom the problem seems, in my opinion to disappear.
I have done a quick test loading an example file and scrolling and zooming seem to be right
The file I linked is already corrected.

Regards
Giovanni

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Impossible to scroll page tabs (left-right) on Mac and how to compile

Hi Giovanni and many thanks for your works, very gracefull. ;-)

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."