• Tom789
  • Nouveau membre
  • Offline

Topic: Regression 0.80 > 0.90: Line thickness

Dear All,

While playing around with qet 0.80 and 0.90, I noted a possible regression that you may want to address in 0.100.

  • I created an arrow as user collection element with a tip using line thickness "thin" (see ElementEditor.png)

  • When placed on a folio in 0.80 the arrow tip is correctly included (see QET080.png)

  • However, if the same file is displayed with 0.90, the tip is drawn with thickness "normal" (see QET090.png)

It seems, that somehow the line thickness of the tip is ignored in 0.90.

Regards
Tom

Post's attachments

ElementEditor.png, 1.86 kb, 359 x 362
ElementEditor.png 1.86 kb, 40 downloads since 2024-03-15 

QET080.png, 7.06 kb, 301 x 304
QET080.png 7.06 kb, 38 downloads since 2024-03-15 

QET090.png, 7.13 kb, 304 x 306
QET090.png 7.13 kb, 43 downloads since 2024-03-15 

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Regression 0.80 > 0.90: Line thickness

Hello Tom,

you saw the  same thing in the nightly 0.100 version?

For information, certain bugs found after the release of version 0.90 and resolved in 0.100-dev have been backported to the 0.9.1 branch:
https://github.com/qelectrotech/qelectr … its/0.9.1/


Regards,
Laurent

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Regression 0.80 > 0.90: Line thickness

Element created on 0.8 AppImage version!

Show on 0.8 AppImage
https://download.qelectrotech.org/qet/forum_img_2/thin_0.8.png

Show on 0.100-dev
https://download.qelectrotech.org/qet/forum_img_2/thin_0.100.png

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • Tom789
  • Nouveau membre
  • Offline

Re: Regression 0.80 > 0.90: Line thickness

Hi Laurent,

to be honest, I did not check the nightly 0.100 version. You see, I was curious about the 0.100 version, but did not want to compile it on a regular basis, so I installed the ppa and upgraded qet from 0.80 to 0.100. I spent some time playing with the 0.100 version and got the feeling that the 0.100 is too much "work in progress" for me. So I rolled back to 0.80 and as a compromise downloaded and installed the source of 0.90.

Anyhow, your screenshots show me that you are already aware of that issue and have it addressed. Excellent. I am looking forward to the release of 0.100.

Regards
Tom

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Regression 0.80 > 0.90: Line thickness

Hi Tom,

I think you'll have to wait a very long time, as version 0.100 will only be released when Joshua has finished the immense work on the new terminal block generator.

https://youtu.be/sCK_ZeosWsQ

Unfortunately, his wife is suffering from very serious health problems, so he doesn't even have time to boot up his computer in his spare time.

As for me, my health is still too precarious, and since my burn-out and other major health problems, I've been less involved in development than before...

https://qelectrotech.org/forum/viewtopi … 216#p19216


Regards,
Laurent

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • Tom789
  • Nouveau membre
  • Offline

Re: Regression 0.80 > 0.90: Line thickness

Hi Laurent,

I am sorry. I did not know and now I understand better. So, I hope Joshua's wife is getting better soon and that you are recovering as soon and as best as possible. I am crossing my fingers for you all.

Best wishes to France,
Tom

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Regression 0.80 > 0.90: Line thickness

Thanks Tom.

Best wishes from France,
Laurent

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."
  • Tom789
  • Nouveau membre
  • Offline

Re: Regression 0.80 > 0.90: Line thickness

Hi Laurent,

I would like to give it a try and fix the thickness issue in the qet 0.90 code. Do you maybe have a hint for me, what file(s) of the source code may be responsible for this issue?

Thanks
Tom

  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Regression 0.80 > 0.90: Line thickness

Hi Tom,

try on 0.100.0 dev if problem it is , we don't fix old 0.90 release now!


Regards,
Laurent

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."

Re: Regression 0.80 > 0.90: Line thickness

Hey Tom,

I am older than Laurent(scorpio810) and I also have health problems.

Install QtCreator

Create Project => Import project


File => Open File or Project
Edit => Find/Replace => Advanced Find => Project

Search for : thickness

/qelectrotech-source-mirror/lang/qet_en.ts
/qelectrotech-source-mirror/sources/editor/graphicspart/partdynamictextfield.cpp
/qelectrotech-source-mirror/sources/editor/styleeditor.h
/qelectrotech-source-mirror/sources/qetgraphicsitem/conductor.cpp
/qelectrotech-source-mirror/sources/qetgraphicsitem/dynamicelementtextitem.cpp
/qelectrotech-source-mirror/sources/qetgraphicsitem/elementtextitemgroup.cpp

Regards,
Erik

I am an pre-retired industrial developer technician and born in 1960
  • scorpio810
  • scorpio810
  • QElectroTech Team Manager, Developer, Packager
  • Offline

Re: Regression 0.80 > 0.90: Line thickness

Hey Tom

https://github.com/qelectrotech/qelectr … r.cpp#L206

"Le jour où tu découvres le Libre, tu sais que tu ne pourras jamais plus revenir en arrière..."