View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000309 | QElectroTech | Diagram Editor | public | 2024-07-16 13:22 | 2024-10-04 16:03 |
| Reporter | tester | Assigned To | |||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | new | Resolution | open | ||
| Platform | X64 | OS | Windows | OS Version | 10+ |
| Summary | 0000309: Not focusing diagram view on search hit | ||||
| Description | Even on latest 0.10 build to date when searching on a string in a diagram, selecting one of the hit will enable a blue hallow highlight on the matching diagram element. But the problem is that on a huge diagram when there are scrollbars, and you only see part of the diagram at a time, select will not focus the diagram on the location of that particular element. On huge diagram, search thus very painfull as you have to scroll each time all around to seek for the blue hallow highlighted element. My expectation whould be that if the selected element is not visible, a scroll is applied to the location so that the item is in the middle of the view. If the element is visible then nothing is done outside the existing behabiour (blue hallow highlight). | ||||
| Steps To Reproduce | Open a huge diagram, resize the window so that scrollbar exists. Search for a text on an element that is not visible on the diagram. The scroll view will not move when selecting that item. | ||||
| Tags | No tags attached. | ||||
|
|
Hello, if you can, please make a little video about your problem. |
|
|
Hello, Here is a quid video. I create on a big diagram two items with name label respectively "test" and "truc". When in plain sight you can see the item and the blue highlight. But when not, there is no scrolling at all, so you have no idea where the item is located on your diagrame. You will have to either pan to an unknown location or zoom out, find the blue zone and then zoom in. This is really painfull. My expectation was that the blue highlighting feature also pan the view to the location of the selected/matched item. Rgs |
|
|
I think the code doing the focusing in that search context is around searchandreplacewidget.cpp#L1022 There seem to be only highlighting done here (+ no signal) and no code to scroll the view to ensure m_highlighted_element is in plain sight. It look like we have to move the H&V QScrollBar of the view from horizontalScrollBar() and verticalScrollBar() using their setValue(...) to move the view of the DiagramView ... Example of a scroll code https://github.com/qelectrotech/qelectrotech-source-mirror/blob/59253019ffe263da779562803fd8d6641b84b70a/sources/diagramview.cpp#L816C1-L876C1 but it is done on selected Elements and not highlighted though. Rgs |
|
|
tester> PI, j'ai mis à jour le 0000309 dans Mantis avec quelques axes de résolution. Malheureusement, je n'ai pas trouvé un truc sur les Element type .focusInView() ou sur le DiagramView de .showElement(Element ou ElementData). Merci de ton retour, hélas je ne suis plus tres present sur le chan IRC. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-07-16 13:22 | tester | New Issue | |
| 2024-07-16 17:54 | scorpio810_mantis | Note Added: 0000732 | |
| 2024-07-24 02:15 | tester | Note Added: 0000734 | |
| 2024-07-24 02:15 | tester | File Added: 2024-07-24 02-04-59.mkv | |
| 2024-10-02 10:51 | tester | Note Added: 0000749 | |
| 2024-10-02 11:12 | tester | Note Edited: 0000749 | |
| 2024-10-02 11:29 | tester | Note Edited: 0000749 | |
| 2024-10-04 16:03 | scorpio810_mantis | Note Added: 0000752 |
