QElectroTech — deprecated fix patch files

Re: deprecated fix patch files

null@example.com (scorpio810) — Mon, 08 Jun 2020 20:30:29 +0000

Thanks Simon.

Re: deprecated fix patch files

null@example.com (De-Backer) — Mon, 08 Jun 2020 19:00:01 +0000

last patch:

QAbstractTableModel explicitly initialized in copy constructor

warning: base class ‘class QAbstractTableModel’
should be explicitly initialized in the copy constructor [-Wextra]

Re: deprecated fix patch files

null@example.com (De-Backer) — Sun, 07 Jun 2020 21:16:27 +0000

De-Backer wrote:

warning: ‘QSet QList::toSet() const [with T = IndependentTextItem*]’ is deprecated:
Use QSet(list.begin(), list.end()) instead. [-Wdeprecated-declarations]
-5 issues for QT 5.14

don't forget

Re: deprecated fix patch files

null@example.com (scorpio810) — Sun, 07 Jun 2020 17:51:26 +0000

Thanks Simon.

Re: deprecated fix patch files

null@example.com (De-Backer) — Sun, 07 Jun 2020 11:41:01 +0000

scorpio810 wrote:

I tried "0001-fix-deprecated-Wdeprecated-copy.patch" is reduce warnings 50 to 6, but I don't know if I can push it?
First patch in attached patch reduce warnings 50 -> ~20.

i think this is the answer, use default default constructor (does only shallow copy).

Re: deprecated fix patch files

null@example.com (De-Backer) — Sun, 07 Jun 2020 08:42:27 +0000

* fix_deprecated_QModelIndex
warning: ‘QModelIndex QModelIndex::child(int, int) const’ is deprecated: Use QAbstractItemModel::index [-Wdeprecated-declarations]

-11 issues

Re: deprecated fix patch files

null@example.com (De-Backer) — Sun, 07 Jun 2020 08:20:28 +0000

attempt 2 for deprecated warning QList::swap(int i, int j)

scorpio810 wrote:

I had to revert it
https://git.tuxfamily.org/qet/qet.git/c … e91882a445
Edit : ok I understood, I use Qt version 5.12.5 and this function was introduced in Qt 5.13.

*fix deprecated warning QList::swap(int i, int j)

Re: deprecated fix patch files

null@example.com (De-Backer) — Sun, 07 Jun 2020 08:18:35 +0000

warning: ‘typename Container::const_iterator qUpperBound(const Container&, const T&) [with Container = QList; T = double; typename Container::const_iterator = QList::const_iterator]’ is deprecated: Use std::upper_bound [-Wdeprecated-declarations]

-3 issues Qt -> C++ (should be ok, no version differences)

Re: deprecated fix patch files

null@example.com (De-Backer) — Sun, 07 Jun 2020 08:14:21 +0000

warning: ‘QSet QList::toSet() const [with T = IndependentTextItem*]’ is deprecated:
Use QSet(list.begin(), list.end()) instead. [-Wdeprecated-declarations]

-5 issues for QT 5.14

Re: deprecated fix patch files

null@example.com (De-Backer) — Thu, 04 Jun 2020 21:15:49 +0000

warning: base class ‘class QAbstractTableModel’ should be explicitly initialized in the copy constructor [-Wextra]

sources/qetgraphicsitem/ViewItem/nomenclaturemodel.cpp:46:1:

-NomenclatureModel::NomenclatureModel(const NomenclatureModel &other_model)
+NomenclatureModel::NomenclatureModel(const NomenclatureModel &other_model) :
+    QAbstractTableModel(this),
+    m_project(project())

is ok?
info of https://stackoverflow.com/questions/211 … onstructor

Re: deprecated fix patch files

null@example.com (scorpio810) — Tue, 02 Jun 2020 16:03:37 +0000

Merged, thanks.

Re: deprecated fix patch files

null@example.com (De-Backer) — Mon, 01 Jun 2020 20:54:45 +0000

fix_deprecated_drawRoundRect
warning: ‘void QPainter::drawRoundRect(const QRectF&, int, int)’ is deprecated: Use drawRoundedRect(..., Qt::RelativeSize) instead [-Wdeprecated-declarations]

void QPainter::drawRoundRect(const QRectF &r, int xRnd = 25, int yRnd = 25)
This function is obsolete. It is provided to keep old source code working. We strongly advise against using it in new code.

void QPainter::drawRoundedRect(const QRectF &rect, qreal xRadius, qreal yRadius, Qt::SizeMode mode = Qt::AbsoluteSize)
Draws the given rectangle rect with rounded corners.
The xRadius and yRadius arguments specify the radii of the ellipses defining the corners of the rounded rectangle. When mode is Qt::RelativeSize, xRadius and yRadius are specified in percentage of half the rectangle's width and height respectively, and should be in the range 0.0 to 100.0.
A filled rectangle has a size of rect.size(). A stroked rectangle has a size of rect.size() plus the pen width.

QRectF rectangle(10.0, 20.0, 80.0, 60.0);

QPainter painter(this);
painter.drawRoundedRect(rectangle, 20.0, 15.0);

This function was introduced in Qt 4.4.

Re: deprecated fix patch files

null@example.com (scorpio810) — Mon, 01 Jun 2020 09:55:27 +0000

FYI, AppImage use now Qt 5.15.0.
https://invent.kde.org/sdk/kdesrc-build/-/issues/45

Re: deprecated fix patch files

null@example.com (scorpio810) — Mon, 01 Jun 2020 09:54:15 +0000

Merged, thanks.

Re: deprecated fix patch files

null@example.com (De-Backer) — Mon, 01 Jun 2020 07:52:12 +0000

linksingleelementwidget.cpp:482:28: warning: 'setBackgroundColor' is deprecated: Use QTreeWidgetItem::setBackground() instead
qtreewidget.h:141:5: note: 'setBackgroundColor' has been explicitly marked deprecated here
qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'
qcompilerdetection.h:675:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'

"linksingleelementwidget.cpp"
@@ -478,11 +478,11 @@ void LinkSingleElementWidget::linkTriggered()

- m_qtwi_at_context_menu->setBackgroundColor(i, Qt::green);
+ m_qtwi_at_context_menu->setBackground(i, QBrush(Qt::green,Qt::SolidPattern));

void QTreeWidgetItem::setBackgroundColor(int column, const QColor &color)
This function is deprecated. Use setBackground() instead.
See also backgroundColor().

void QTreeWidgetItem::setBackground(int column, const QBrush &brush)
Sets the background brush of the label in the given column to the specified brush. Setting a default-constructed brush will let the view use the default color from the style.
Note: If Qt Style Sheets are used on the same widget as setBackground(), style sheets will take precedence if the settings conflict.
This function was introduced in Qt 4.2.